Skip to content

fix: images related issues #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GoodluckH merged 2 commits into from
May 9, 2025
Merged

fix: images related issues #1753

GoodluckH merged 2 commits into from
May 9, 2025

Conversation

@GoodluckH
Copy link
Contributor

@GoodluckH GoodluckH commented May 9, 2025 •
edited
Loading

  • Fixed the uncleaned styling after tool call
  • Don't throw when a slash file path is provided at the beginning of the user input

@GoodluckH GoodluckH requested a review from a team May 9, 2025 17:44
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.75%. Comparing base (dd39398) to head (d083cc1).
Report is 243 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1753   +/-   ##
=======================================
  Coverage   16.75%   16.75%           
=======================================
  Files         213      213           
  Lines       20704    20704           
  Branches      871      871           
=======================================
  Hits         3468     3468           
  Misses      17236    17236

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GoodluckH GoodluckH requested a review from brandonskiser May 9, 2025 17:47
@GoodluckH GoodluckH changed the title fix: reset terminal attributes after adding tool results fix: images related issues May 9, 2025
@GoodluckH GoodluckH force-pushed the xipu/image-print-fix branch from 6c2b6d9 to 97255a0 Compare May 9, 2025 19:49
@GoodluckH GoodluckH force-pushed the xipu/image-print-fix branch from de0580c to d083cc1 Compare May 9, 2025 20:45
@GoodluckH GoodluckH merged commit 52b5455 into main May 9, 2025
21 checks passed
@GoodluckH GoodluckH deleted the xipu/image-print-fix branch May 9, 2025 20:46
This was referenced May 10, 2025
Merged
Merged
@brandonskiser brandonskiser mentioned this pull request May 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaynabors chaynabors chaynabors approved these changes

@brandonskiser brandonskiser Awaiting requested review from brandonskiser

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GoodluckH @codecov-commenter @chaynabors